Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the issue where Tac Console TGUI was showing armour quadrants on on crafts that do not have armour quadrants. #2549

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

Bobbanz1
Copy link
Contributor

About The Pull Request

This PR fixes the following issue:

By changing stuff around in both the TGUI file and the DM file, long story short it should now only display the armour quadrants if the ship is not a small craft, if it is then it will instead display the armour plating integrity of the small craft itself!

Fixes #2409

Why It's Good For The Game

Prevents stuff like this from happening, also bug fixes are usually good!

image

Testing Photographs and Procedure

Screenshots&Videos

Skärmbild 2023-09-27 122450
Skärmbild 2023-09-27 122530

Changelog

🆑
fix: Fixes the issue where small crafts such as Sabres, dropships and ghost ships were showing non-existing armour quadrants!
/:cl:

…n on crafts that do not have armour quadrants.
Bokkiewokkie
Bokkiewokkie previously approved these changes Sep 29, 2023
Copy link
Contributor

@Bokkiewokkie Bokkiewokkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just works (I hope)

@Bokkiewokkie Bokkiewokkie added Overmap This issue or PR is related to overmap interactions Active Test Merge labels Sep 29, 2023
@Bokkiewokkie Bokkiewokkie self-requested a review October 17, 2023 22:00
@Bokkiewokkie Bokkiewokkie merged commit 41ded1a into BeeStation:master Oct 27, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Active Test Merge Fix Overmap This issue or PR is related to overmap interactions TGUI-Changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intergrated Tactical Console TGUI showing armour quadrant field on craft that do not have armour quadrants.
3 participants